linux-kernel - Re: [PATCH 1/3] scripts/sorttable: Change section type of orc_lookup to SHT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200724135531.GB648324@gmail.com>
Date:   Fri, 24 Jul 2020 15:55:31 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Huaixin Chang <changhuaixin@...ux.alibaba.com>,
        Masahiro Yamada <masahiroy@...nel.org>
Cc:     jpoimboe@...hat.com, bp@...en8.de, hpa@...or.com,
        linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        luto@...capital.net, michal.lkml@...kovi.net, mingo@...hat.com,
        peterz@...radead.org, tglx@...utronix.de, x86@...nel.org,
        yamada.masahiro@...ionext.com
Subject: Re: [PATCH 1/3] scripts/sorttable: Change section type of orc_lookup
 to SHT_PROGBITS


* Huaixin Chang <changhuaixin@...ux.alibaba.com> wrote:

> In order to edit orc_lookup table via sorttable, type of section
> orc_lookup needs to be SHT_PROGBITS instead of SHT_NOBITS.
> 
> Linker script doesn't seem to allow manual specification of the section
> type, so just write a byte into the section instead.
> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> Signed-off-by: Huaixin Chang <changhuaixin@...ux.alibaba.com>
> Signed-off-by: Shile Zhang <shile.zhang@...ux.alibaba.com>
> ---
>  include/asm-generic/vmlinux.lds.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index db600ef218d7..49f4f5bc6165 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -826,6 +826,8 @@
>  		. += (((SIZEOF(.text) + LOOKUP_BLOCK_SIZE - 1) /	\
>  			LOOKUP_BLOCK_SIZE) + 1) * 4;			\
>  		orc_lookup_end = .;					\
> +		/* HACK: force SHT_PROGBITS so sorttable can edit: */	\
> +		BYTE(1);						\

Cc:-ing Masahiro Yamada, maybe there's a cleaner solution to this?

Thanks,

	Ingo