linux-kernel - Re: [PATCH for v5.9] USB: serial: Replace HTTP links with HTTPS ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200724144536.GP3634@localhost>
Date:   Fri, 24 Jul 2020 16:45:36 +0200
From:   Johan Hovold <johan@...nel.org>
To:     "Alexander A. Klimov" <grandmaster@...klimov.de>
Cc:     johan@...nel.org, gregkh@...uxfoundation.org, corbet@....net,
        linux-usb@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH for v5.9] USB: serial: Replace HTTP links with HTTPS ones

On Sun, Jul 19, 2020 at 06:19:20PM +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
> 
> Deterministic algorithm:
> For each file:
>   If not .svg:
>     For each line:
>       If doesn't contain `\bxmlns\b`:
>         For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> 	  If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
>             If both the HTTP and HTTPS versions
>             return 200 OK and serve the same content:
>               Replace HTTP with HTTPS.
> 
> Signed-off-by: Alexander A. Klimov <grandmaster@...klimov.de>
> ---
>  Continuing my work started at 93431e0607e5.
>  See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@...klimov.de>' v5.7..master
>  (Actually letting a shell for loop submit all this stuff for me.)
> 
>  If there are any URLs to be removed completely
>  or at least not (just) HTTPSified:
>  Just clearly say so and I'll *undo my change*.
>  See also: https://lkml.org/lkml/2020/6/27/64
> 
>  If there are any valid, but yet not changed URLs:
>  See: https://lkml.org/lkml/2020/6/26/837
> 
>  If you apply the patch, please let me know.
> 
>  Sorry again to all maintainers who complained about subject lines.
>  Now I realized that you want an actually perfect prefixes,
>  not just subsystem ones.
>  I tried my best...
>  And yes, *I could* (at least half-)automate it.
>  Impossible is nothing! :)
> 
> 
>  Documentation/usb/usb-serial.rst  |  2 +-
>  drivers/usb/serial/cyberjack.c    |  2 +-
>  drivers/usb/serial/ftdi_sio.h     |  4 ++--
>  drivers/usb/serial/ftdi_sio_ids.h | 34 +++++++++++++++----------------
>  drivers/usb/serial/kobil_sct.c    |  2 +-
>  drivers/usb/serial/metro-usb.c    |  2 +-
>  6 files changed, 23 insertions(+), 23 deletions(-)
> 
> diff --git a/Documentation/usb/usb-serial.rst b/Documentation/usb/usb-serial.rst
> index 8fa7dbd3da9a..0a2071953691 100644
> --- a/Documentation/usb/usb-serial.rst
> +++ b/Documentation/usb/usb-serial.rst
> @@ -202,7 +202,7 @@ Keyspan USA-series Serial Adapters
>  
>    More information is available at:
>  
> -        http://www.carnationsoftware.com/carnation/Keyspan.html
> +        https://www.carnationsoftware.com/carnation/Keyspan.html
>  
>    For any questions or problems with this driver, please contact Hugh
>    Blemings at hugh@...c.nu

Looks like your script is buggy; there are many more URLs than this one
is this document.

> diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
> index e8373528264c..a5bf2b974813 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -60,14 +60,14 @@
>  /*
>   * Texas Instruments XDS100v2 JTAG / BeagleBone A3
>   * http://processors.wiki.ti.com/index.php/XDS100
> - * http://beagleboard.org/bone
> + * https://beagleboard.org/bone
>   */

And here's another indication of that.

Johan