linux-kernel - RE: [PATCH V2 2/3] gpio: xilinx: Add interrupt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR02MB5386E88C8E3CA66987B452BFAF770@DM6PR02MB5386.namprd02.prod.outlook.com>
Date:   Fri, 24 Jul 2020 14:56:11 +0000
From:   Srinivas Neeli <sneeli@...inx.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        kernel test robot <lkp@...el.com>
CC:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Michal Simek <michals@...inx.com>,
        Shubhrajyoti Datta <shubhraj@...inx.com>,
        Srinivas Goud <sgoud@...inx.com>,
        "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        git <git@...inx.com>
Subject: RE: [PATCH V2 2/3] gpio: xilinx: Add interrupt support

Hi Linus,

Thanks for the review

> -----Original Message-----
> From: Linus Walleij <linus.walleij@...aro.org>
> Sent: Friday, July 24, 2020 2:52 PM
> To: kernel test robot <lkp@...el.com>
> Cc: Srinivas Neeli <sneeli@...inx.com>; Bartosz Golaszewski
> <bgolaszewski@...libre.com>; Michal Simek <michals@...inx.com>;
> Shubhrajyoti Datta <shubhraj@...inx.com>; Srinivas Goud
> <sgoud@...inx.com>; kbuild-all@...ts.01.org; open list:GPIO SUBSYSTEM
> <linux-gpio@...r.kernel.org>; Linux ARM <linux-arm-
> kernel@...ts.infradead.org>; linux-kernel@...r.kernel.org; git
> <git@...inx.com>
> Subject: Re: [PATCH V2 2/3] gpio: xilinx: Add interrupt support
> 
> On Fri, Jul 24, 2020 at 6:12 AM kernel test robot <lkp@...el.com> wrote:
> 
> >    drivers/gpio/gpio-xilinx.c: In function 'xgpio_probe':
> >    drivers/gpio/gpio-xilinx.c:638:10: error: 'struct gpio_chip' has no member
> named 'of_gpio_n_cells'
> >      638 |  chip->gc.of_gpio_n_cells = cells;
> >          |          ^
> > >> drivers/gpio/gpio-xilinx.c:639:10: error: 'struct gpio_chip' has no
> member named 'of_xlate'
> >      639 |  chip->gc.of_xlate = xgpio_xlate;
> >          |          ^
> 
> This is probably because your driver needs:
> 
> depends on OF_GPIO
> 
> in KConfig
> 
I will address in v3.

> Yours,
> Linus Walleij