linux-kernel - Re: [PATCH v3 2/2] mtd: rawnand: ingenic: Limit MTD_NAND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <PWBZDQ.D1XCW6N2YMRA@crapouillou.net>
Date:   Fri, 24 Jul 2020 17:19:37 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Harvey Hunt <harveyhuntnexus@...il.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v3 2/2] mtd: rawnand: ingenic: Limit MTD_NAND_JZ4780 to
 architecture only

Hi Krzysztof,


Le ven. 24 juil. 2020 à 16:54, Krzysztof Kozlowski <krzk@...nel.org> a 
écrit :
> Enabling the MTD_NAND_JZ4780 driver makes sense only for specific
> hardware - the Ingenic SoC architecture.  Set it's dependency to
> MACH_INGENIC so it will not appear on unrelated architectures (easier
> job for downstream/distro kernel engineers).

Disagreed. It was done this way so that distro kernels can support 
multiple SoCs.

-Paul

> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> 
> ---
> 
> Changes since v2:
> 1. New patch
> ---
>  drivers/mtd/nand/raw/ingenic/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/ingenic/Kconfig 
> b/drivers/mtd/nand/raw/ingenic/Kconfig
> index 96c5ae8b1bbc..2e3936543ba6 100644
> --- a/drivers/mtd/nand/raw/ingenic/Kconfig
> +++ b/drivers/mtd/nand/raw/ingenic/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config MTD_NAND_JZ4780
>  	tristate "JZ4780 NAND controller"
> -	depends on MIPS || COMPILE_TEST
> +	depends on MACH_INGENIC || COMPILE_TEST
>  	depends on JZ4780_NEMC
>  	help
>  	  Enables support for NAND Flash connected to the NEMC on JZ4780 SoC
> --
> 2.17.1
>