linux-kernel - Re: [PATCH] svc: add missed destroy_workqueue when gb_svc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200725072936.GQ3634@localhost>
Date:   Sat, 25 Jul 2020 09:29:36 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Li Heng <liheng40@...wei.com>
Cc:     johan@...nel.org, elder@...nel.org, gregkh@...uxfoundation.org,
        viresh.kumar@...aro.org, greybus-dev@...ts.linaro.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] svc: add missed destroy_workqueue when gb_svc_create
 fails

On Sat, Jul 25, 2020 at 11:06:37AM +0800, Li Heng wrote:
> destroy_workqueue() should be called to destroy svc->wq
> when gb_svc_create() init resources fails.
> 
> Fixes: 8465def499c7 ("staging: greybus: move the greybus core to drivers/greybus")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Li Heng <liheng40@...wei.com>
> ---
>  drivers/greybus/svc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/greybus/svc.c b/drivers/greybus/svc.c
> index ce7740e..38f858f 100644
> --- a/drivers/greybus/svc.c
> +++ b/drivers/greybus/svc.c
> @@ -1340,6 +1340,7 @@ struct gb_svc *gb_svc_create(struct gb_host_device *hd)
>  
>  err_put_device:
>  	put_device(&svc->dev);
> +	destroy_workqueue(svc->wq);

Your bot is broken; the workqueue is released in gb_svc_release(). 

And please fix your internal review process so that you catch things
like this before posting.

>  	return NULL;
>  }

Johan