linux-kernel - Re: [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3N70PbotC18K-SG9+XgfApHNZyCYvUgOyfrxrP55zSEw@mail.gmail.com>
Date:   Sat, 25 Jul 2020 09:57:41 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
Cc:     "arm@...nel.org" <arm@...nel.org>, Olof Johansson <olof@...om.net>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Murali Karicheri <m-karicheri2@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Sekhar Nori <nsekhar@...com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "David S . Miller" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        Oleksij Rempel <o.rempel@...gutronix.de>,
        Andrew Lunn <andrew@...n.ch>,
        Philippe Schenker <philippe.schenker@...adex.com>
Subject: Re: [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for
 ksz9031 phy

On Fri, Jul 24, 2020 at 11:57 PM santosh.shilimkar@...cle.com
<santosh.shilimkar@...cle.com> wrote:
> On 7/24/20 2:42 PM, Grygorii Strashko wrote:
> > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
> > KSZ9031 PHY") the networking is broken on keystone-k2g-evm board.
> >
> > The above board have phy-mode = "rgmii-id" and it is worked before because
> > KSZ9031 PHY started with default RGMII internal delays configuration (TX
> > off, RX on 1.2 ns) and MAC provided TX delay by default.
> > After above commit, the KSZ9031 PHY starts handling phy mode properly and
> > enables both RX and TX delays, as result networking is become broken.
> >
> > Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
> > behavior.
> >
> > Cc: Oleksij Rempel <o.rempel@...gutronix.de>
> > Cc: Andrew Lunn <andrew@...n.ch>
> > Cc: Philippe Schenker <philippe.schenker@...adex.com>
> > Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> > ---
> > Fix for one more broken TI board with KSZ9031 PHY.
> Can you please apply this patch to your v5.8 fixes branch and send it
> upstream ? Without the fix K2G EVM board is broken with v5.8.
>
> Am hoping you can pick this up with pull request since it just one
> patch.

I've applied it now, but would point out that it's generally better if you could
forward the patch to soc@...nel.org with your Signed-off-by if you come
across a similar patch again. That way it ends up in patchwork, and we
are more likely to pick it up quickly.

       Arnd