linux-kernel - Re: [PATCH] nbd: add missed destroy_workqueue when nbd_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <d7b60d29-4a02-ae2a-fa9d-0c4918eba91a@web.de>
Date:   Sat, 25 Jul 2020 12:50:29 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Li Heng <liheng40@...wei.com>, linux-block@...r.kernel.org,
        nbd@...er.debian.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jens Axboe <axboe@...nel.dk>,
        Josef Bacik <josef@...icpanda.com>
Subject: Re: [PATCH] nbd: add missed destroy_workqueue when nbd_start_device
 fails

> destroy_workqueue() should be called to destroy ndev->tx_wq
> when nbd_start_device init resources fails.

* An imperative wording can be preferred for the change description,
  can't it?

* Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus