linux-kernel - Re: [PATCH] Fix one coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200725110526.GA396778@kroah.com>
Date:   Sat, 25 Jul 2020 13:05:26 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Anant Thazhemadam <anant.thazhemadam@...il.com>
Cc:     Merwin Trever Ferrao <merwintf@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Joe Perches <joe@...ches.com>,
        Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [PATCH] Fix one coding style issue

On Sat, Jul 25, 2020 at 04:00:03PM +0530, Anant Thazhemadam wrote:
> The coding style issue that raised an error (upon checking against
> checkpatch.pl) has been fixed.

You are not saying what issue was fixed.

Also, your subject line needs to be fixed, please see the link provided
by the bot previously for what to do.

> Exactly one coding style issue has been fixed; as required by Task 10
> of the Eudyptula Challenge.

We don't care why you are doing this work, no need to put that in the
changelog.

> 
> Signed-off-by: Anant Thazhemadam <anant.thazhemadam@...il.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_security.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
> index 21f6652dd69f..dc22ee9c24ad 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_security.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_security.c
> @@ -718,7 +718,9 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
>  				res = _FAIL;
>  			}
>  		} else {
> -			RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
> +			RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
> +				 ("%s: stainfo==NULL!!!\n", __func__)
> +				);

Very odd line breaks, this now looks worse than before :(

thanks,

greg k-h