linux-kernel - Re: [PATCH net-next v4 1/2] hinic: add support to handle hw abnormal event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200724.170415.1190789583922952011.davem@davemloft.net>
Date:   Fri, 24 Jul 2020 17:04:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     luobin9@...wei.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        luoxianjun@...wei.com, yin.yinshi@...wei.com,
        cloud.wangxiaoyun@...wei.com, chiqijun@...wei.com
Subject: Re: [PATCH net-next v4 1/2] hinic: add support to handle hw
 abnormal event

From: Luo bin <luobin9@...wei.com>
Date: Fri, 24 Jul 2020 17:17:31 +0800

> +static int hinic_fw_reporter_dump(struct devlink_health_reporter *reporter,
> +				  struct devlink_fmsg *fmsg, void *priv_ctx,
> +				  struct netlink_ext_ack *extack)
> +{
> +	int err;
> +
> +	if (priv_ctx) {
> +		err = mgmt_watchdog_report_show(fmsg, priv_ctx);
> +		if (err)
> +			return err;
> +	}
> +
> +	return 0;
> +}

As Edward Cree pointed out for v3 of this patch series, this 'err' is not
necessary at all.