linux-kernel - Re: [PATCH v2] ARM: milbeaut: Add missing of_node_put() call in m10v_smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 25 Jul 2020 14:02:55 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Yi Wang <wang.yi59@....com.cn>,
        Liao Pingfang <liao.pingfang@....com.cn>,
        linux-arm-kernel@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Russell King <linux@...linux.org.uk>,
        Wang Liang <wang.liang82@....com.cn>,
        Xue Zhihong <xue.zhihong@....com.cn>
Subject: Re: [PATCH v2] ARM: milbeaut: Add missing of_node_put() call in
 m10v_smp_init()

> The variable np in function m10v_smp_init takes the return value
> of of_find_compatible_node, which gets a node but does not put it.

Such information is useful.


> If this node is not put it may cause a memory leak.

Is the reference management generally improvable for this function implementation?


Will the tag “Fixes” become helpful for the commit message?

Regards,
Markus