linux-kernel - Re: [PATCH 1/1] STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style Error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aab59eb1-baff-5de1-4e14-88ffc42db1fe@lwfinger.net>
Date:   Sat, 25 Jul 2020 12:47:48 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Anant Thazhemadam <anant.thazhemadam@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Anoop S <anoop.skumar1507@...il.com>,
        Michael Straube <straube.linux@...il.com>,
        Joe Perches <joe@...ches.com>,
        Merwin Trever Ferrao <merwintf@...il.com>,
        Rahul Gottipati <rahul.blr97@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style
 Error

On 7/25/20 7:20 AM, Anant Thazhemadam wrote:
> Running the checkpatch.pl script on the file for which patch was created, the
> following error was found to exist.
> ERROR: space required after that ',' (ctx:VxV)
> 
> Fixed the above error which was found on line #721 by inserting a blank
> space at the appropriate position.
> 
> Signed-off-by: Anant Thazhemadam <anant.thazhemadam@...il.com>
> ---
>   drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
> index 21f6652dd69f..57e171d3e48d 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_security.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_security.c
> @@ -718,7 +718,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
>   				res = _FAIL;
>   			}
>   		} else {
> -			RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
> +			RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n", __func__));
>   			res = _FAIL;
>   		}
>   	}

In fixing one checkpatch.pl condition, you introduced another - the resulting 
line is too long. You should fix only one such condition, but you should fix any 
others that are introduced. You do need to document it.

Patch subjects for this driver should be written as "staging: rtl8188eu: .....".

Larry