linux-kernel - Re: [PATCH] tools/perf-bench: Add basic syscall benchmark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200726141626.GN77866@kernel.org>
Date:   Sun, 26 Jul 2020 11:16:26 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     Davidlohr Bueso <dave@...olabs.net>,
        Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>,
        Ingo Molnar <mingo@...nel.org>, mgorman@...hsingularity.net,
        linux-kernel@...r.kernel.org, Davidlohr Bueso <dbueso@...e.de>,
        Namhyung Kim <namhyung@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>
Subject: Re: [PATCH] tools/perf-bench: Add basic syscall benchmark

Em Thu, May 14, 2020 at 03:39:42PM -0500, Josh Poimboeuf escreveu:
> On Fri, Mar 08, 2019 at 10:17:47AM -0800, Davidlohr Bueso wrote:
> > On Thu, 07 Mar 2019, Arnaldo Carvalho de Melo wrote:
> > > You forgot to update tools/perf/Documentation/perf-bench.txt, and please
> > > take a look at tools/perf/util/pmu.c convert_scale() to see how to save
> > > the current locale, set the one you want, then restore the previous one,
> > > so that at the end of this benchmark the environment is back to where it
> > > was.
> > 
> > Here's an updated version with the corresponding docs, but I removed the
> > setlocale() - doesn't seem worth it; I hope Mel has no strong objection.
> > 
> > Thanks.
> > 
> > -------8<----------------------------------------------------------
> > [PATCH v2] tools/perf-bench: Add basic syscall benchmark
> > 
> > The usefulness of having a standard way of testing syscall performance
> > has come up from time to time[0]. Furthermore, some of our testing
> > machinery (such as 'mmtests') already makes use of a simplified version
> > of the microbenchmark. This patch mainly takes the same idea to measure
> > syscall throughput compatible with 'perf-bench' via getppid(2), yet
> > without any of the additional template stuff from Ingo's version (based
> > on numa.c). The code is identical to what mmtests uses.
> > 
> > [0] https://lore.kernel.org/lkml/20160201074156.GA27156@gmail.com/
> > 
> > Signed-off-by: Davidlohr Bueso <dbueso@...e.de>
> 
> It would be nice to see this merged.  I posted something very similar
> back in 2016.

So, I took this as an Acked-by: Josh, and the previous "no objection"
from Mel as well, its now in my tmp.perf/core branch while it, together
with other stuff goes thru build tests + 'perf test'.

Sorry for the long delay in processing it, I shoudl've noticed that my
review comments were addressed in v2.

- Arnaldo