linux-kernel - Re: [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 Jul 2020 17:26:42 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     linux-wireless@...r.kernel.org
Cc:     Johannes Berg <johannes.berg@...el.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Luca Coelho <luciano.coelho@...el.com>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware
 is missing

On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote:
> Missing this firmware is not fatal, my wifi card still works. Even more,
> I couldn't find any documentation what it is or where to get it. So, I
> don't think the users should be notified if it is missing. If you browse
> the net, you see the message is present is in quite some logs. Better
> remove it.
> 
> Signed-off-by: Wolfram Sang <wsa@...nel.org>
> ---

Any input on this? Or people I should add to CC?

> 
> This is only build tested because I wanted to get your opinions first. I
> couldn't find any explanation about yoyo, so I am entering unknown
> territory here.
> 
>  drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
> index 7987a288917b..f180db2936e3 100644
> --- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
> +++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
> @@ -468,7 +468,7 @@ void iwl_dbg_tlv_load_bin(struct device *dev, struct iwl_trans *trans)
>  	if (!iwlwifi_mod_params.enable_ini)
>  		return;
>  
> -	res = request_firmware(&fw, "iwl-debug-yoyo.bin", dev);
> +	res = firmware_request_nowarn(&fw, "iwl-debug-yoyo.bin", dev);
>  	if (res)
>  		return;
>  
> -- 
> 2.20.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)