linux-kernel - Re: [PATCH] init/do_mounts: fix a coding style error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 26 Jul 2020 10:50:55 -0700
From:   Joe Perches <joe@...ches.com>
To:     Al Viro <viro@...iv.linux.org.uk>,
        zhouchuangao <chuangaozhou@...il.com>
Cc:     linux@...inikbrodowski.net, pc@....nz, axboe@...nel.dk,
        dhowells@...hat.com, linux-kernel@...r.kernel.org,
        zhouchuangao <zhouchuangao@...omi.com>
Subject: Re: [PATCH] init/do_mounts: fix a coding style error

On Sun, 2020-07-26 at 18:21 +0100, Al Viro wrote:
> On Tue, Jul 14, 2020 at 03:02:58PM +0800, zhouchuangao wrote:
> > Fix code style errors reported by scripts/checkpatch.pl.
> 
> NAKed-because: excessive deference to checkpatch.pl
> 
> It's not a holy oracle than needs to be appeased, no questions
> asked.  Reference to it is absolutely insufficient reason for
> _anything_ - in effect your commit message could've been
> "just because" for all the information it contains.

Al is right.

Something that could useful is to avoid using printks without
a KERN_<LEVEL> or add KERN_CONT to some continuation printks.

Maybe:
---
diff --git a/init/do_mounts.c b/init/do_mounts.c
index 4f4ceb358055..3f37d859cf2a 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -468,8 +468,8 @@ void __init mount_block_root(char *name, int flags)
 	printk_all_partitions();
 	printk("No filesystem could mount root, tried: ");
 	for (p = fs_names; *p; p += strlen(p)+1)
-		printk(" %s", p);
-	printk("\n");
+		pr_cont(" %s", p);
+	pr_cont("\n");
 	panic("VFS: Unable to mount root fs on %s", b);
 out:
 	put_page(page);