linux-kernel - Re: [PATCH -next] power: Convert to DEFINE_SHOW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200726220949.m456hoqcb5bis4ry@earth.universe>
Date:   Mon, 27 Jul 2020 00:09:49 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Qinglang Miao <miaoqinglang@...wei.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] power: Convert to DEFINE_SHOW_ATTRIBUTE

Hi,

On Thu, Jul 16, 2020 at 04:58:49PM +0800, Qinglang Miao wrote:
> From: Yongqiang Liu <liuyongqiang13@...wei.com>
> 
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
> 
> Signed-off-by: Yongqiang Liu <liuyongqiang13@...wei.com>

Thanks, queued.

-- Sebastian

>  drivers/power/supply/da9030_battery.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/drivers/power/supply/da9030_battery.c b/drivers/power/supply/da9030_battery.c
> index 292ecf875..0deba48d2 100644
> --- a/drivers/power/supply/da9030_battery.c
> +++ b/drivers/power/supply/da9030_battery.c
> @@ -172,17 +172,7 @@ static int bat_debug_show(struct seq_file *s, void *data)
>  	return 0;
>  }
>  
> -static int debug_open(struct inode *inode, struct file *file)
> -{
> -	return single_open(file, bat_debug_show, inode->i_private);
> -}
> -
> -static const struct file_operations bat_debug_fops = {
> -	.open		= debug_open,
> -	.read_iter		= seq_read_iter,
> -	.llseek		= seq_lseek,
> -	.release	= single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(bat_debug);
>  
>  static struct dentry *da9030_bat_create_debugfs(struct da9030_charger *charger)
>  {
> -- 
> 2.17.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)