linux-kernel - Re: [PATCH v6 0/9] hwmon: pmbus: adm1266: add support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Jul 2020 07:10:10 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     alexandru.tachici@...log.com, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Cc:     robh+dt@...nel.org
Subject: Re: [PATCH v6 0/9] hwmon: pmbus: adm1266: add support

On 7/26/20 10:31 PM, alexandru.tachici@...log.com wrote:
> From: Alexandru Tachici <alexandru.tachici@...log.com>
> 
> Add PMBus probing driver for the adm1266 Cascadable
> Super Sequencer with Margin Control and Fault Recording.
> Driver is using the pmbus_core, creating sysfs files
> under hwmon for inputs: vh1->vh4 and vp1->vp13.
> 

What happened to change logs ? Do you really expect me
to go through the history of this series to figure out
what changed from and in previous revisions of this
patch set ?

Guenter

> 1. Add PMBus probing driver for inputs vh1->vh4
> and vp1->vp13.
> 
> 2. Add Block Write-Read Process Call command.
> A PMBus specific implementation was required because
> block write with I2C_SMBUS_PROC_CALL flag allows a
> maximum of 32 bytes to be received.
> 
> 3. This makes adm1266 driver expose GPIOs
> to user-space. Currently are read only. Future
> developments on the firmware will allow
> them to be writable.
> 
> 4. Allow the current sate of the seqeuncer to be read
> through debugfs.
> 
> 5. Blackboxes are 64 bytes of chip state related data
> that is generated on faults. Use the nvmem kernel api
> to expose the blackbox chip functionality to userspace.
> 
> 6. Add group command support. This will allow the driver
> to stop/program all cascaded adm1266 devices at once.
> 
> 7. Writing the firmware hex file with offset 0
> to the nvmem of the master adm1266 will trigger
> the firmware programming of all cascaded devices.
> The master adm1266 of each device is specified in
> the devicetree.
> 
> 8. Writing the configuration hex file to 0x30000
> byte address of the nvmem file will trigger the
> programing of that device in particular.
> 
> 9. dt bindings for ADM1266.
> 
> Alexandru Tachici (9):
>   hwmon: pmbus: adm1266: add support
>   hwmon: pmbus: adm1266: Add Block process call
>   hwmon: pmbus: adm1266: Add support for GPIOs
>   hwmon: pmbus: adm1266: add debugfs for states
>   hwmon: pmbus: adm1266: read blackbox
>   hwmon: pmbus: adm1266: Add group command support
>   hwmon: pmbus: adm1266: program firmware
>   hwmon: pmbus: adm1266: program configuration
>   dt-bindings: hwmon: Add bindings for ADM1266
> 
>  .../bindings/hwmon/adi,adm1266.yaml           |   56 +
>  Documentation/hwmon/adm1266.rst               |   37 +
>  Documentation/hwmon/index.rst                 |    1 +
>  drivers/hwmon/pmbus/Kconfig                   |   10 +
>  drivers/hwmon/pmbus/Makefile                  |    1 +
>  drivers/hwmon/pmbus/adm1266.c                 | 1273 +++++++++++++++++
>  6 files changed, 1378 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml
>  create mode 100644 Documentation/hwmon/adm1266.rst
>  create mode 100644 drivers/hwmon/pmbus/adm1266.c
>