linux-kernel - Re: [PATCH] KVM: Using macros instead of magic values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <92cd8fd2-d838-a1e3-dc39-7e6e5c4e68ca@redhat.com>
Date:   Mon, 27 Jul 2020 16:40:03 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Haiwei Li <lihaiwei.kernel@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>
Cc:     Sean Christopherson <sean.j.christopherson@...el.com>,
        "wanpengli@...cent.com" <wanpengli@...cent.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "jmattson@...gle.com" <jmattson@...gle.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>, mingo@...hat.com,
        "bp@...en8.de" <bp@...en8.de>, "hpa@...or.com" <hpa@...or.com>
Subject: Re: [PATCH] KVM: Using macros instead of magic values

On 21/07/20 10:23, Haiwei Li wrote:
> From: Haiwei Li <lihaiwei@...cent.com>
> 
> Instead of using magic values, use macros.
> 
> Signed-off-by: Haiwei Li <lihaiwei@...cent.com>
> ---
>  arch/x86/kvm/lapic.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> index 47801a4..d5fb2ea 100644
> --- a/arch/x86/kvm/lapic.c
> +++ b/arch/x86/kvm/lapic.c
> @@ -2083,7 +2083,8 @@ int kvm_lapic_reg_write(struct kvm_lapic *apic,
> u32 reg, u32 val)
> 
>      case APIC_SELF_IPI:
>          if (apic_x2apic_mode(apic)) {
> -            kvm_lapic_reg_write(apic, APIC_ICR, 0x40000 | (val & 0xff));
> +            kvm_lapic_reg_write(apic, APIC_ICR,
> +                        APIC_DEST_SELF | (val & APIC_VECTOR_MASK));
>          } else
>              ret = 1;
>          break;
> -- 
> 1.8.3.1
> 

Queued, thanks.

Paolo