linux-kernel - Re: [PATCH 2/2] drm/radeon: avoid a useless memset

Open Source and information security mailing list archives

Message-ID: <CADnq5_OqdUxSKv21pg9o=a_dwyW7-j3URy+BYHrS+ubzuA-7NQ@mail.gmail.com>
Date:   Mon, 27 Jul 2020 14:11:58 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Christian Koenig <christian.koenig@....com>
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        "Deucher, Alexander" <alexander.deucher@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        kernel-janitors@...r.kernel.org,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] drm/radeon: avoid a useless memset

Applied.  Thanks!

Alex

On Mon, Jul 27, 2020 at 9:41 AM Christian König
<ckoenig.leichtzumerken@...il.com> wrote:
>
> Am 27.07.20 um 12:34 schrieb Christophe JAILLET:
> > Avoid a memset after a call to 'dma_alloc_coherent()'.
> > This is useless since
> > commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*")
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
>
> Reviewed-by: Christian König <christian.koenig@....com>
>
> > ---
> >   drivers/gpu/drm/radeon/radeon_gart.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_gart.c b/drivers/gpu/drm/radeon/radeon_gart.c
> > index b7ce254e5663..3808a753127b 100644
> > --- a/drivers/gpu/drm/radeon/radeon_gart.c
> > +++ b/drivers/gpu/drm/radeon/radeon_gart.c
> > @@ -85,7 +85,6 @@ int radeon_gart_table_ram_alloc(struct radeon_device *rdev)
> >       }
> >   #endif
> >       rdev->gart.ptr = ptr;
> > -     memset((void *)rdev->gart.ptr, 0, rdev->gart.table_size);
> >       return 0;
> >   }
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives