linux-kernel - Re: (resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6F764B9B-DEE6-4060-9F11-050D2F0999ED@oracle.com>
Date:   Mon, 27 Jul 2020 15:38:38 -0500
From:   John Donnelly <john.p.donnelly@...cle.com>
To:     Sasha Levin <sashal@...nel.org>
Cc:     Mike Snitzer <snitzer@...hat.com>, stable@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: (resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough
 writes in parallel to origin and cache



> On Jul 27, 2020, at 3:17 PM, Sasha Levin <sashal@...nel.org> wrote:
> 
> On Mon, Jul 27, 2020 at 02:38:52PM -0500, John Donnelly wrote:
>> 
>> 
>>> On Jul 27, 2020, at 2:18 PM, Sasha Levin <sashal@...nel.org> wrote:
>>> 
>>> On Mon, Jul 27, 2020 at 11:00:14AM -0400, Mike Snitzer wrote:
>>>> This mail needs to be saent to stable@...r.kernel.org (now cc'd).
>>>> 
>>>> Greg et al: please backport 2df3bae9a6543e90042291707b8db0cbfbae9ee9
>>> 
>>> Hm, what's the issue that this patch addresses? It's not clear from the
>>> commit message.
>>> 
>>> --
>>> Thanks,
>>> Sasha
>> 
>> HI Sasha ,
>> 
>> In an off-line conversation I had with Mike , he indicated that :
>> 
>> 
>> commit 1b17159e52bb31f982f82a6278acd7fab1d3f67b
>> Author: Mike Snitzer <snitzer@...hat.com>
>> Date:   Fri Feb 28 18:00:53 2020 -0500
>> 
>>  dm bio record: save/restore bi_end_io and bi_integrity
>> 
>> 
>> commit 248aa2645aa7fc9175d1107c2593cc90d4af5a4e
>> Author: Mike Snitzer <snitzer@...hat.com>
>> Date:   Fri Feb 28 18:11:53 2020 -0500
>> 
>>  dm integrity: use dm_bio_record and dm_bio_restore
>> 
>> 
>> Were picked up  in  "stable" kernels picked up even though
>> neither was marked for stable@...r.kernel.org
>> 
>> Adding this missing  commit :
>> 
>> 2df3bae9a6543e90042291707b8db0cbfbae9ee9
>> 
>> 
>> Completes the series
> 
> Should we just revert those two commits instead if they're not needed?
> 
> -- 
> Thanks,
> Sasha

  As I stated above:

> Fixes: 705559706d62038b74c5088114c1799cf2c9dce8 (dm bio record:
> save/restore bi_end_io and bi_integrity, version 4.14.188)
> 
> 70555970 introduced a mkfs.ext4 hang on a LVM device that has been
> modified with lvconvert --cachemode=writethrough.

  It corrects an issue we discovered in 4.14.188 .    Any other branches those two commits have migrated to will likely have the same regression. 

I am confident linux-4.14.y will  be better off with it ;-)