linux-kernel - Re: [PATCH v2] sched,tracing: Convert to sched_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200727165614.5d0f4346@oasis.local.home>
Date:   Mon, 27 Jul 2020 16:56:14 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     kernel test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        Ingo Molnar <mingo@...nel.org>, sfr@...b.auug.org.au
Subject: Re: [PATCH v2] sched,tracing: Convert to sched_set_fifo()

On Sat, 25 Jul 2020 18:58:16 +0200
Peter Zijlstra <peterz@...radead.org> wrote:

> On Fri, Jul 24, 2020 at 06:18:46PM -0400, Steven Rostedt wrote:
> > On Fri, 24 Jul 2020 23:50:03 +0200
> > peterz@...radead.org wrote:
> >   
> > > -	if (producer_fifo < 0)
> > > +	if (producer_fifo)
> > > +		trace_printk("Running Producer at SCHED_FIFO %s\n",
> > > +			     consumer_fifo == 1 ? "low" : "high");  
> > 
> > I'm going to take cut-and-paste away from you!  
> 
> Well, yes, I said so, I also already have it fixed.

I thought you're comment on IRC was about v1, as I read it before
seeing v2.

> 
> Aside from that, is the patch ok?

Beside this, yes.

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve