linux-kernel - Re: [PATCH] checkpatch: improve MAINTAINERS file update test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <0801ef9d2489ed816ec97ee3054de2d20bfac14c.camel@perches.com>
Date:   Mon, 27 Jul 2020 14:07:05 -0700
From:   Joe Perches <joe@...ches.com>
To:     Daniel Dadap <ddadap@...dia.com>, apw@...onical.com
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: improve MAINTAINERS file update test

On Mon, 2020-07-27 at 15:58 -0500, Daniel Dadap wrote:
> Add an additional regular expression to detect updates to the
> MAINTAINERS file as reported in the unified diffs generated by
> `git format-patch`. This suppresses the "does MAINTAINERS need
> updating" message when MAINTAINERS is updated with this format.

Please cc at least LKML.

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2621,7 +2621,8 @@ sub process {
>  
>  # Check if MAINTAINERS is being updated.  If so, there's probably no need to
>  # emit the "does MAINTAINERS need updating?" message on file add/move/delete
> -		if ($line =~ /^\s*MAINTAINERS\s*\|/) {
> +		if ($line =~ /^\s*MAINTAINERS\s*\|/ ||
> +		    $line =~ /^[-+]{3} [ab]\/MAINTAINERS$/) {

I don't believe this works well as any test
for a file modification to MAINTAINERS occurs
after the block that would show a diffstat
where the warning is emitted.