linux-kernel - [PATCH -next] leds: fix LEDS_LP55XX_COMMON dependency and build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <dba79c02-b7f1-dd75-b364-93d90538cc5e@infradead.org>
Date:   Mon, 27 Jul 2020 16:57:11 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     LKML <linux-kernel@...r.kernel.org>, linux-leds@...r.kernel.org,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        Milo Kim <milo.kim@...com>,
        Mathias Nyman <mathias.nyman@...ia.com>
Subject: [PATCH -next] leds: fix LEDS_LP55XX_COMMON dependency and build
 errors

From: Randy Dunlap <rdunlap@...radead.org>

Make LEDS_LP55XX_COMMON depend on I2C to fix build errors:

leds-lp55xx-common.c:(.text+0x9d): undefined reference to `i2c_smbus_read_byte_data'
leds-lp55xx-common.c:(.text+0x8fc): undefined reference to `i2c_smbus_write_byte_data'

These errors happened when I2C=m and LEDS_LP55XX_COMMON=y, so
prevent that from being possible.

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc: Pavel Machek <pavel@....cz>
Cc: Dan Murphy <dmurphy@...com>
Cc: linux-leds@...r.kernel.org
Cc: Milo Kim <milo.kim@...com>
Cc: Mathias Nyman <mathias.nyman@...ia.com>
---
 drivers/leds/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20200727.orig/drivers/leds/Kconfig
+++ linux-next-20200727/drivers/leds/Kconfig
@@ -399,6 +399,7 @@ config LEDS_LP55XX_COMMON
 	tristate "Common Driver for TI/National LP5521/5523/55231/5562/8501"
 	depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR
 	depends on OF
+	depends on I2C
 	select FW_LOADER
 	select FW_LOADER_USER_HELPER
 	help