linux-kernel - Re: [PATCHv2 2/2] perf tools: Fix term parsing for raw syntax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d30edad-8df1-ac9d-c70d-9019935c4d4c@linux.intel.com>
Date:   Mon, 27 Jul 2020 08:21:07 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Michael Petlan <mpetlan@...hat.com>,
        Ian Rogers <irogers@...gle.com>,
        Stephane Eranian <eranian@...gle.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Thomas Richter <tmricht@...ux.ibm.com>
Subject: Re: [PATCHv2 2/2] perf tools: Fix term parsing for raw syntax



On 7/26/2020 3:52 PM, Jiri Olsa wrote:
> Jin Yao reported issue with possible conflict between raw
> events and term values in pmu event syntax.
> 
> Currently following syntax is resolved as raw event with
> 0xead value:
>    uncore_imc_free_running/read/
> 
> instead of using 'read' term from uncore_imc_free_running pmu,
> because 'read' is correct raw event syntax with 0xead value.
> 
> To solve this issue we do following:
>    - check existing terms during rXXXX syntax processing
>      and make them priority in case of conflict
>    - allow pmu/r0x1234/ syntax to be able to specify conflicting
>      raw event (implemented in previous patch)
> 
> Also adding automated tests for this and perf_pmu__parse_cleanup
> call to parse_events_terms, so the test gets properly cleaned up.
> 
> Reported-by: Jin Yao<yao.jin@...ux.intel.com>
> Signed-off-by: Jiri Olsa<jolsa@...nel.org>
> ---
> v2 changes:
>   - added comment to perf_pmu__test_parse_init

Acked-by: Jin Yao <yao.jin@...ux.intel.com>

Thanks
Jin Yao