linux-kernel - Re: [PATCH v2] tpm: Fix the description error of the help information in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Jul 2020 10:32:04 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
Cc:     Christophe Ricard <christophe.ricard@...il.com>,
        Peter Huewe <peterhuewe@....de>,
        Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        gregkh <gregkh@...uxfoundation.org>,
        linux-integrity@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] tpm: Fix the description error of the help information
 in Kconfig

On Mon, Jul 27, 2020 at 10:22 AM Tianjia Zhang
<tianjia.zhang@...ux.alibaba.com> wrote:
>
> SPI protocol standardized by the TCG is described in the TCG PTP
> specification 1.3 (chapter 6.4.6 SPI Bit Protocol), It was published by
> TCG_PCClientTPMInterfaceSpecification_TIS__1-3_27_03212013.pdf.

I'm still not convinced you got this right, the document you cite only
seems to mention TPM 1.2 as the base for TIS 1.3, but not TPM 1.3.

     Arnd

> The TPM version number in the help message is wrong, which will
> cause confusion. This patch fixes it.
>
> Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
> Signed-off-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
> ---
>  drivers/char/tpm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index 58b4c573d176..8eedb3e704f3 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -62,7 +62,7 @@ config TCG_TIS_SPI
>         help
>           If you have a TPM security chip which is connected to a regular,
>           non-tcg SPI master (i.e. most embedded platforms) that is compliant with the
> -         TCG TIS 1.3 TPM specification (TPM1.2) or the TCG PTP FIFO
> +         TCG TIS 1.3 TPM specification (TPM1.3) or the TCG PTP FIFO
>           specification (TPM2.0) say Yes and it will be accessible from
>           within Linux. To compile this driver as a module, choose  M here;
>           the module will be called tpm_tis_spi.
> --
> 2.17.1
>