linux-kernel - Re: [PATCH] PCI/P2PDMA: Add AMD Zen 2 root complex to the list of allowed bridges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200727102024.00005f8b@Huawei.com>
Date:   Mon, 27 Jul 2020 10:20:24 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Logan Gunthorpe <logang@...tatee.com>
CC:     Bjorn Helgaas <helgaas@...nel.org>,
        Alex Deucher <alexdeucher@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux PCI <linux-pci@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Christian König <christian.koenig@....com>,
        Huang Rui <ray.huang@....com>,
        Andrew Maier <andrew.maier@...eticom.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Eric Wehage <Eric.Wehage@...urewei.com>,
        "Alex Umansky" <alex.umansky@...wei.com>
Subject: Re: [PATCH] PCI/P2PDMA: Add AMD Zen 2 root complex to the list of
 allowed bridges

On Fri, 24 Jul 2020 09:56:39 -0600
Logan Gunthorpe <logang@...tatee.com> wrote:

> [+cc Jonathan]
> 
> On 2020-07-24 9:06 a.m., Bjorn Helgaas wrote:
> > On Thu, Jul 23, 2020 at 02:10:52PM -0600, Logan Gunthorpe wrote:  
> >> On 2020-07-23 1:57 p.m., Bjorn Helgaas wrote:  
> >>> On Thu, Jul 23, 2020 at 02:01:17PM -0400, Alex Deucher wrote:  
> >>>> On Thu, Jul 23, 2020 at 1:43 PM Logan Gunthorpe <logang@...tatee.com> wrote:  
> >>>>>
> >>>>> The AMD Zen 2 root complex (Starship/Matisse) was tested for P2PDMA
> >>>>> transactions between root ports and found to work. Therefore add it
> >>>>> to the list.
> >>>>>
> >>>>> Signed-off-by: Logan Gunthorpe <logang@...tatee.com>
> >>>>> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> >>>>> Cc: Christian König <christian.koenig@....com>
> >>>>> Cc: Huang Rui <ray.huang@....com>
> >>>>> Cc: Alex Deucher <alexdeucher@...il.com>  
> >>>>
> >>>> Starting with Zen, all AMD platforms support P2P for reads and writes.  
> >>>
> >>> What's the plan for getting out of the cycle of "update this list for
> >>> every new chip"?  Any new _DSMs planned, for instance?  
> >>
> >> Well there was an effort to add capabilities in the PCI spec to describe
> >> this but, as far as I know, they never got anywhere, and hardware still
> >> doesn't self describe with this.  
> > 
> > Any idea what happened?  Is there hope for the future?  I'm really not
> > happy about signing up for open-ended device-specific patches like
> > this.  It's certainly not in the plug and play spirit that has made
> > PCI successful.  I know, preaching to the choir here.  
> 
> Agreed, though I'm not really hooked into the PCI SIG. The last email I
> got about this was an RFC from Jonathan Cameron in late 2018. I've CC'd
> him here, maybe he'll have a bit more insight.

For non technical reasons, you can probably figure out, that particular
ECR stalled. Unfortunately I can't directly provide info on any newer
discussions. Eric, could you perhaps find out if there is anything we can share?

This is the same question of trying to find a way to avoid white listing
root complexes that can do peer 2 peer that would have been covered by
your Advanced Peer to Peer Capabilities ECR.

Thanks,

Jonathan





> 
> Logan