linux-kernel - Re: [PATCH] udf: use common error code for unclean filesystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200727121250.GN23179@quack2.suse.cz>
Date:   Mon, 27 Jul 2020 14:12:50 +0200
From:   Jan Kara <jack@...e.cz>
To:     Pavel Machek <pavel@....cz>
Cc:     jack@...e.com, linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH] udf: use common error code for unclean filesystem

On Sun 26-07-20 09:58:28, Pavel Machek wrote:
> 
> Use common error code for unclean filesystem, and warn when
> incosistency is detected.
> 
> Signed-off-by: Pavel Machek (CIP) <pavel@...x.de>

So this is going in the right direction but there are *much* more places
that would need a similar treatment (furthermore I'd prefer to use the
EFSCORRUPTED redefine of EUCLEAN as other filesystems do). Any reason why
you converted this particular place?

								Honza

> 
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index adaba8e8b326..8e74c7b5b8d0 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -1395,7 +1395,10 @@ static int udf_read_inode(struct inode *inode, bool hidden_inode)
>  	if (iinfo->i_alloc_type != ICBTAG_FLAG_AD_SHORT &&
>  	    iinfo->i_alloc_type != ICBTAG_FLAG_AD_LONG &&
>  	    iinfo->i_alloc_type != ICBTAG_FLAG_AD_IN_ICB) {
> -		ret = -EIO;
> +		ret = -EUCLEAN;
> +		udf_err(inode->i_sb, "invalid allocation type: %u\n",
> +			iinfo->i_alloc_type);
> +
>  		goto out;
>  	}
>  	iinfo->i_unique = 0;
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR