linux-kernel - Re: [PATCH 2/7] sfc: drop unnecessary list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8564082-0dad-a1a7-9d2e-198b429b58d4@solarflare.com>
Date:   Mon, 27 Jul 2020 13:13:40 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     Julia Lawall <Julia.Lawall@...ia.fr>,
        Solarflare linux maintainers <linux-net-drivers@...arflare.com>
CC:     <kernel-janitors@...r.kernel.org>,
        Martin Habets <mhabets@...arflare.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/7] sfc: drop unnecessary list_empty

On 26/07/2020 11:58, Julia Lawall wrote:
> list_for_each_safe is able to handle an empty list.
> The only effect of avoiding the loop is not initializing the
> index variable.
> Drop list_empty tests in cases where these variables are not
> used.
Sure, why not.
Acked-by: Edward Cree <ecree@...arflare.com>