linux-kernel - Re: [PATCH] intel_soc_pmic_mrfld: simplify the return expression of intel_scu_ipc_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Jul 2020 13:53:35 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Xu Wang <vulab@...as.ac.cn>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] intel_soc_pmic_mrfld: simplify the return expression of
 intel_scu_ipc_dev_iowrite8()

On Mon, 27 Jul 2020, Andy Shevchenko wrote:

> On Mon, Jul 27, 2020 at 03:04:07AM +0000, Xu Wang wrote:
> > Simplify the return expression.
> 
> I understand your intention, but I would rather leave as is.
> It's a bit more helpful in the original form in case to add some debugging.

If you wish to add debugging, you'll have to add the extra line of
code yourself. :)

> It also keep it symmetrical with read() counterpart.

Can this be fixed-up too?

> That said, I'm not objecting the change if Lee finds it good enough.
> 
> > Signed-off-by: Xu Wang <vulab@...as.ac.cn>
> > ---
> >  drivers/mfd/intel_soc_pmic_mrfld.c | 7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog