[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJZ5v0gPLp2FdP15-g6G=RksmcqyF4v1a01=2jhoXj0P9ii0Tg@mail.gmail.com>
Date: Mon, 27 Jul 2020 15:24:04 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Colin King <colin.king@...onical.com>
Cc: "Rafael J . Wysocki" <rjw@...ysocki.net>,
Len Brown <lenb@...nel.org>, James Morse <james.morse@....com>,
Tony Luck <tony.luck@...el.com>,
Borislav Petkov <bp@...en8.de>,
ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
kernel-janitors@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: APEI: remove redundant assignment to variable rc
On Wed, Jul 22, 2020 at 7:06 PM Colin King <colin.king@...onical.com> wrote:
>
> From: Colin Ian King <colin.king@...onical.com>
>
> The variable rc is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
> drivers/acpi/apei/hest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
> index 953a2fae8b15..6e980fe16772 100644
> --- a/drivers/acpi/apei/hest.c
> +++ b/drivers/acpi/apei/hest.c
> @@ -227,7 +227,7 @@ __setup("hest_disable", setup_hest_disable);
> void __init acpi_hest_init(void)
> {
> acpi_status status;
> - int rc = -ENODEV;
> + int rc;
> unsigned int ghes_count = 0;
>
> if (hest_disable) {
> --
Applied as 5.9 material, thanks!
Powered by blists - more mailing lists