linux-kernel - Re: Re: [PATCH] Staging: rtl8188eu: rtw_mlme: Fix uninitialized variable authmode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1721a94f.13572.173908057cb.Coremail.dinghao.liu@zju.edu.cn>
Date:   Mon, 27 Jul 2020 21:39:57 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Larry Finger" <Larry.Finger@...inger.net>
Cc:     "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, kjlu@....edu,
        "Shreeya Patel" <shreeya.patel23498@...il.com>,
        "Julia Lawall" <julia.lawall@...ia.fr>,
        "Michael Straube" <straube.linux@...il.com>,
        "Stefano Brivio" <sbrivio@...hat.com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] Staging: rtl8188eu: rtw_mlme: Fix uninitialized
 variable authmode

> 
> Yes, in this routine, it would be possible for authmode to not be set; however, 
> later code only compares it to either _WPA_IE_ID_ or _WPA2_IE_ID_. It is never 
> used in a way that an unset value could make the program flow be different by 
> arbitrarily setting the value to zero. Thus your statement "Then authmode may 
> contain a garbage value and influence the execution flow of this function." is 
> false.
> 

It's clear to me. Thank you for your advice.

Regards,
Dinghao