linux-kernel - [PATCH][next] counter: microchip-tcb-capture: remove ATMEL_TC_ETRGEDG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Jul 2020 15:06:00 +0100
From:   Colin King <colin.king@...onical.com>
To:     Kamel Bouhara <kamel.bouhara@...tlin.com>,
        William Breathitt Gray <vilhelm.gray@...il.com>,
        linux-iio@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH][next] counter: microchip-tcb-capture: remove ATMEL_TC_ETRGEDG_NONE bit check

From: Colin Ian King <colin.king@...onical.com>

The macro ATMEL_TC_ETRGEDG_NONE is defined as 0 << 8 which is zero and
hence the check cmr & ATMEL_TC_ETRGEDG_NONE can never be true. Since
*action is already assigned MCHP_TC_SYNAPSE_ACTION_NONE then this check
and set is redundant dead code and can be removed.

Addresses-Coverity: ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/counter/microchip-tcb-capture.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c
index f7b7743ddb94..119640d6d6ab 100644
--- a/drivers/counter/microchip-tcb-capture.c
+++ b/drivers/counter/microchip-tcb-capture.c
@@ -185,9 +185,7 @@ static int mchp_tc_count_action_get(struct counter_device *counter,
 
 	*action = MCHP_TC_SYNAPSE_ACTION_NONE;
 
-	if (cmr & ATMEL_TC_ETRGEDG_NONE)
-		*action = MCHP_TC_SYNAPSE_ACTION_NONE;
-	else if (cmr & ATMEL_TC_ETRGEDG_RISING)
+	if (cmr & ATMEL_TC_ETRGEDG_RISING)
 		*action = MCHP_TC_SYNAPSE_ACTION_RISING_EDGE;
 	else if (cmr & ATMEL_TC_ETRGEDG_FALLING)
 		*action = MCHP_TC_SYNAPSE_ACTION_FALLING_EDGE;
-- 
2.27.0