linux-kernel - Re: [PATCH v4 10/10] module: Reorder functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200728172907.GA31178@linux-8ccs>
Date:   Tue, 28 Jul 2020 19:29:08 +0200
From:   Jessica Yu <jeyu@...nel.org>
To:     Kristen Carlson Accardi <kristen@...ux.intel.com>
Cc:     keescook@...omium.org, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        arjan@...ux.intel.com, linux-kernel@...r.kernel.org,
        kernel-hardening@...ts.openwall.com, rick.p.edgecombe@...el.com,
        Ard Biesheuvel <ardb@...nel.org>,
        Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH v4 10/10] module: Reorder functions

+++ Kristen Carlson Accardi [17/07/20 10:00 -0700]:
>Introduce a new config option to allow modules to be re-ordered
>by function. This option can be enabled independently of the
>kernel text KASLR or FG_KASLR settings so that it can be used
>by architectures that do not support either of these features.
>This option will be selected by default if CONFIG_FG_KASLR is
>selected.
>
>If a module has functions split out into separate text sections
>(i.e. compiled with the -ffunction-sections flag), reorder the
>functions to provide some code diversification to modules.
>
>Signed-off-by: Kristen Carlson Accardi <kristen@...ux.intel.com>
>Reviewed-by: Kees Cook <keescook@...omium.org>
>Acked-by: Ard Biesheuvel <ardb@...nel.org>
>Tested-by: Ard Biesheuvel <ardb@...nel.org>
>Reviewed-by: Tony Luck <tony.luck@...el.com>
>Tested-by: Tony Luck <tony.luck@...el.com>

Hi Kristen!

I've boot tested this on x86, (un)loaded some modules, and checked
their resulting section addresses as a quick sanity test. Feel free
to add my:

Acked-by: Jessica Yu <jeyu@...nel.org>
Tested-by: Jessica Yu <jeyu@...nel.org>

Thank you!

Jessica