linux-kernel - Re: [PATCH] power: supply: rt5033_battery: Fix error code in rt5033_battery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200728001937.vtvneczrskc6cs4u@earth.universe>
Date:   Tue, 28 Jul 2020 02:19:37 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Peng Fan <fanpeng@...ngson.cn>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        Tiezhu Yang <yangtiezhu@...ngson.cn>
Subject: Re: [PATCH] power: supply: rt5033_battery: Fix error code in
 rt5033_battery_probe()

Hi,

On Thu, Jul 02, 2020 at 04:58:52PM +0800, Peng Fan wrote:
> In the function rt5033_battery_probe(), it should return -ENOMEM
> instead of -EINVAL when call function devm_kzalloc() failed.
> 
> Signed-off-by: Peng Fan <fanpeng@...ngson.cn>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/rt5033_battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/rt5033_battery.c b/drivers/power/supply/rt5033_battery.c
> index d8667a9..f330452 100644
> --- a/drivers/power/supply/rt5033_battery.c
> +++ b/drivers/power/supply/rt5033_battery.c
> @@ -125,7 +125,7 @@ static int rt5033_battery_probe(struct i2c_client *client,
>  
>  	battery = devm_kzalloc(&client->dev, sizeof(*battery), GFP_KERNEL);
>  	if (!battery)
> -		return -EINVAL;
> +		return -ENOMEM;
>  
>  	battery->client = client;
>  	battery->regmap = devm_regmap_init_i2c(client,
> -- 
> 2.1.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)