linux-kernel - Re: [PATCH v2 2/8] x86/kaslr: Remove bogus warning and unnecessary goto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202007281126.A1AD5DE02@keescook>
Date:   Tue, 28 Jul 2020 11:26:54 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Arvind Sankar <nivedita@...m.mit.edu>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/8] x86/kaslr: Remove bogus warning and unnecessary
 goto

On Mon, Jul 27, 2020 at 07:07:55PM -0400, Arvind Sankar wrote:
> Drop the warning on seeing "--" in handle_mem_options. This will trigger
> whenever one of the memory options is present in the command line
> together with "--", but there's no problem if that is the case.
> 
> Replace goto with break.
> 
> Signed-off-by: Arvind Sankar <nivedita@...m.mit.edu>

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook