linux-kernel - Re: [PATCH v4 2/4] power: supply: bq27xxx_battery: Add the BQ27561 Battery monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7035eebd-0324-6cf0-1de7-75eb4524cb94@ti.com>
Date:   Tue, 28 Jul 2020 13:56:45 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Sebastian Reichel <sre@...nel.org>
CC:     <afd@...com>, <pali@...nel.org>, <linux-pm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <robh@...nel.org>
Subject: Re: [PATCH v4 2/4] power: supply: bq27xxx_battery: Add the BQ27561
 Battery monitor

Sebastian

On 7/28/20 1:17 PM, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Jul 28, 2020 at 09:11:11AM -0500, Dan Murphy wrote:
>> Add the Texas Instruments BQ27561 battery monitor.  The register address
>> map is laid out the same as compared to other devices within the file.
>> The battery status register has differing bits to determine if the
>> battery is full, discharging or dead.
>>
>> Signed-off-by: Dan Murphy <dmurphy@...com>
>> ---
>>   drivers/power/supply/bq27xxx_battery.c     | 68 +++++++++++++++++++++-
>>   drivers/power/supply/bq27xxx_battery_i2c.c |  2 +
>>   include/linux/power/bq27xxx_battery.h      |  1 +
>>   3 files changed, 70 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
>> index 942c92127b6d..654d38bcd7e0 100644
>> --- a/drivers/power/supply/bq27xxx_battery.c
>> +++ b/drivers/power/supply/bq27xxx_battery.c
>> @@ -43,6 +43,7 @@
>>    * http://www.ti.com/product/bq27411-g1
>>    * http://www.ti.com/product/bq27441-g1
>>    * http://www.ti.com/product/bq27621-g1
>> + * https://www.ti.com/lit/gpn/bq27z561
> Applying this failed, because I applied a patch converting the
> http urls to https. I would have fixed this silently, but it made
> me notice the chip name is bq27z561 instead of simply bq27561.
>
> You named it without the 'z' everywhere, is there a reason?
> Searching for bq27561 basically only finds your patches and
> you decided not to drop the z for the bq28z610.

At the time I was working on the BQ27750 as well and that has no letters 
in it so I was following that part number.

I will add the z in and rebase so the patch applies cleanly

Dan

>
> -- Sebastian