linux-kernel - Re: [PATCH] mm/slab.c: add node spinlock protect in __cache_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.23.453.2007281238580.2664959@chino.kir.corp.google.com>
Date:   Tue, 28 Jul 2020 12:46:07 -0700 (PDT)
From:   David Rientjes <rientjes@...gle.com>
To:     qiang.zhang@...driver.com
cc:     cl@...ux.com, penberg@...nel.org, iamjoonsoo.kim@....com,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/slab.c: add node spinlock protect in
 __cache_free_alien

On Tue, 28 Jul 2020, qiang.zhang@...driver.com wrote:

> From: Zhang Qiang <qiang.zhang@...driver.com>
> 
> We should add node spinlock protect "n->alien" which may be
> assigned to NULL in cpuup_canceled func. cause address access
> exception.
> 

Hi, do you have an example NULL pointer dereference where you have hit 
this?

This rather looks like something to fix up in cpuup_canceled() since it's 
currently manipulating the alien cache for the canceled cpu's node.

> Fixes: 18bf854117c6 ("slab: use get_node() and kmem_cache_node() functions")
> Signed-off-by: Zhang Qiang <qiang.zhang@...driver.com>
> ---
>  mm/slab.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/slab.c b/mm/slab.c
> index a89633603b2d..290523c90b4e 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -759,8 +759,10 @@ static int __cache_free_alien(struct kmem_cache *cachep, void *objp,
>  
>  	n = get_node(cachep, node);
>  	STATS_INC_NODEFREES(cachep);
> +	spin_lock(&n->list_lock);
>  	if (n->alien && n->alien[page_node]) {
>  		alien = n->alien[page_node];
> +		spin_unlock(&n->list_lock);
>  		ac = &alien->ac;
>  		spin_lock(&alien->lock);
>  		if (unlikely(ac->avail == ac->limit)) {
> @@ -769,14 +771,15 @@ static int __cache_free_alien(struct kmem_cache *cachep, void *objp,
>  		}
>  		ac->entry[ac->avail++] = objp;
>  		spin_unlock(&alien->lock);
> -		slabs_destroy(cachep, &list);
>  	} else {
> +		spin_unlock(&n->list_lock);
>  		n = get_node(cachep, page_node);
>  		spin_lock(&n->list_lock);
>  		free_block(cachep, &objp, 1, page_node, &list);
>  		spin_unlock(&n->list_lock);
> -		slabs_destroy(cachep, &list);
>  	}
> +
> +	slabs_destroy(cachep, &list);
>  	return 1;
>  }
>  
> -- 
> 2.26.2
> 
>