linux-kernel - Re: [PATCH] dmaengine: ti: omap-dma: Drop of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200728195541.GN13753@pendragon.ideasonboard.com>
Date:   Tue, 28 Jul 2020 22:55:41 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Vinod Koul <vkoul@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: ti: omap-dma: Drop of_match_ptr to fix
 -Wunused-const-variable

Hi Krzysztof,

Thank you for the patch.

On Tue, Jul 28, 2020 at 07:09:39PM +0200, Krzysztof Kozlowski wrote:
> The of_device_id is included unconditionally by of.h header and used
> in the driver as well.  Remove of_match_ptr to fix W=1 compile test
> warning with !CONFIG_OF:
> 
>     drivers/dma/ti/omap-dma.c:1892:34: warning: 'omap_dma_match' defined but not used [-Wunused-const-variable=]
>      1892 | static const struct of_device_id omap_dma_match[] = {
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/dma/ti/omap-dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c
> index 918301e17552..c9fe5e3a6b55 100644
> --- a/drivers/dma/ti/omap-dma.c
> +++ b/drivers/dma/ti/omap-dma.c
> @@ -1904,7 +1904,7 @@ static struct platform_driver omap_dma_driver = {
>  	.remove	= omap_dma_remove,
>  	.driver = {
>  		.name = "omap-dma-engine",
> -		.of_match_table = of_match_ptr(omap_dma_match),
> +		.of_match_table = omap_dma_match,
>  	},
>  };
>  

-- 
Regards,

Laurent Pinchart