[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200728201736.GA1277651@ravnborg.org>
Date: Tue, 28 Jul 2020 22:17:36 +0200
From: Sam Ravnborg <sam@...nborg.org>
To: Paul Cercueil <paul@...pouillou.net>
Cc: David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
od@...c.me, linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 0/2] Small cleanups to ingenic-drm driver
Hi Paul.
On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote:
> Here are a few cleanups to the ingenic-drm driver.
> - some error paths were missing and have been added;
> - the mode validation has been moved to the .mode_valid helper callback.
>
> Cheers,
> -Paul
>
> Paul Cercueil (2):
> drm/ingenic: Handle errors of drm_atomic_get_plane_state
> drm/ingenic: Validate mode in a .mode_valid callback
Both looks fine, you can add my:
Reviewed-by: Sam Ravnborg <sam@...nborg.org>
I assume you will apply the patches.
Maybe wait for Daniel to take a look, he had some feedback on where
to add checks. I assume this is covered by the second patch.
Sam
>
> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 41 +++++++++++++++--------
> 1 file changed, 27 insertions(+), 14 deletions(-)
>
> --
> 2.27.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Powered by blists - more mailing lists