linux-kernel - Re: [PATCH v7 3/8] scsi: ufs-qcom: Remove testbus dump in ufs_qcom_dump_dbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8121784a3019723997a16cc6791e5e5a@codeaurora.org>
Date:   Tue, 28 Jul 2020 13:32:09 +0800
From:   hongwus@...eaurora.org
To:     Can Guo <cang@...eaurora.org>
Cc:     asutoshd@...eaurora.org, nguyenb@...eaurora.org,
        rnayak@...eaurora.org, sh425.lee@...sung.com,
        linux-scsi@...r.kernel.org, kernel-team@...roid.com,
        saravanak@...gle.com, salyzyn@...gle.com,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-scsi-owner@...r.kernel.org
Subject: Re: [PATCH v7 3/8] scsi: ufs-qcom: Remove testbus dump in
 ufs_qcom_dump_dbg_regs

On 2020-07-28 13:00, Can Guo wrote:
> Dumping testbus registers is heavy enough to cause stability issues
> sometime, just remove them as of now.
> 
> Signed-off-by: Can Guo <cang@...eaurora.org>
> ---
>  drivers/scsi/ufs/ufs-qcom.c | 32 --------------------------------
>  1 file changed, 32 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index 7da27ee..96e0999 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -1620,44 +1620,12 @@ int ufs_qcom_testbus_config(struct 
> ufs_qcom_host *host)
>  	return 0;
>  }
> 
> -static void ufs_qcom_testbus_read(struct ufs_hba *hba)
> -{
> -	ufshcd_dump_regs(hba, UFS_TEST_BUS, 4, "UFS_TEST_BUS ");
> -}
> -
> -static void ufs_qcom_print_unipro_testbus(struct ufs_hba *hba)
> -{
> -	struct ufs_qcom_host *host = ufshcd_get_variant(hba);
> -	u32 *testbus = NULL;
> -	int i, nminor = 256, testbus_len = nminor * sizeof(u32);
> -
> -	testbus = kmalloc(testbus_len, GFP_KERNEL);
> -	if (!testbus)
> -		return;
> -
> -	host->testbus.select_major = TSTBUS_UNIPRO;
> -	for (i = 0; i < nminor; i++) {
> -		host->testbus.select_minor = i;
> -		ufs_qcom_testbus_config(host);
> -		testbus[i] = ufshcd_readl(hba, UFS_TEST_BUS);
> -	}
> -	print_hex_dump(KERN_ERR, "UNIPRO_TEST_BUS ", DUMP_PREFIX_OFFSET,
> -			16, 4, testbus, testbus_len, false);
> -	kfree(testbus);
> -}
> -
>  static void ufs_qcom_dump_dbg_regs(struct ufs_hba *hba)
>  {
>  	ufshcd_dump_regs(hba, REG_UFS_SYS1CLK_1US, 16 * 4,
>  			 "HCI Vendor Specific Registers ");
> 
> -	/* sleep a bit intermittently as we are dumping too much data */
>  	ufs_qcom_print_hw_debug_reg_all(hba, NULL, 
> ufs_qcom_dump_regs_wrapper);
> -	udelay(1000);
> -	ufs_qcom_testbus_read(hba);
> -	udelay(1000);
> -	ufs_qcom_print_unipro_testbus(hba);
> -	udelay(1000);
>  }
> 
>  /**

Reviewed-by: Hongwu Su <hongwus@...eaurora.org>