linux-kernel - Re: [PATCH bpf-next v2 30/35] bpf: bpftool: do not touch RLIMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzYrN=SJDZ4DC-H7yCBn41p+RgMeWC8KMpkoMpeaRscbUA@mail.gmail.com>
Date:   Mon, 27 Jul 2020 23:00:37 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Roman Gushchin <guro@...com>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next v2 30/35] bpf: bpftool: do not touch RLIMIT_MEMLOCK

On Mon, Jul 27, 2020 at 12:21 PM Roman Gushchin <guro@...com> wrote:
>
> Since bpf stopped using memlock rlimit to limit the memory usage,
> there is no more reason for bpftool to alter its own limits.
>
> Signed-off-by: Roman Gushchin <guro@...com>
> ---

This can't be removed either, due to old kernel support. We probably
should have a helper function to probe RLIMIT_MEMLOCK use by BPF
subsystem, though, and not call set_max_rlimit() is not necessary.

>  tools/bpf/bpftool/common.c     | 7 -------
>  tools/bpf/bpftool/feature.c    | 2 --
>  tools/bpf/bpftool/main.h       | 2 --
>  tools/bpf/bpftool/map.c        | 2 --
>  tools/bpf/bpftool/pids.c       | 1 -
>  tools/bpf/bpftool/prog.c       | 3 ---
>  tools/bpf/bpftool/struct_ops.c | 2 --
>  7 files changed, 19 deletions(-)
>

[...]