linux-kernel - Re: [PATCH] tty/synclink: remove leftover bits of non-PCI card support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200728062045.GA20992@lst.de>
Date:   Tue, 28 Jul 2020 08:20:45 +0200
From:   Christoph Hellwig <hch@....de>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     Christoph Hellwig <hch@....de>, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty/synclink: remove leftover bits of non-PCI card
 support

On Tue, Jul 28, 2020 at 08:05:36AM +0200, Jiri Slaby wrote:
> On 27. 07. 20, 15:05, Christoph Hellwig wrote:
> > Since commit 1355cba9c3ba ("tty/synclink: remove ISA support"), the
> > synlink driver only supports PCI card.  Remove any leftover dead code
> > to support other cards.
> 
> So now you can remove also the defines and bus_type completely:
> $ git grep -E 'MGSL_BUS_TYPE_(E?ISA|PCI)'
> drivers/tty/synclink_gt.c:              info->bus_type = MGSL_BUS_TYPE_PCI;
> drivers/tty/synclinkmp.c:               info->bus_type = MGSL_BUS_TYPE_PCI;
> include/uapi/linux/synclink.h:#define MGSL_BUS_TYPE_ISA 1
> include/uapi/linux/synclink.h:#define MGSL_BUS_TYPE_EISA        2
> include/uapi/linux/synclink.h:#define MGSL_BUS_TYPE_PCI 5

This is in a uapi header, so I didn't dare to touch it.

> 
> $ git grep -w bus_type drivers/tty/synclink*
> drivers/tty/synclink_gt.c:      unsigned int bus_type;
> drivers/tty/synclink_gt.c:              info->bus_type = MGSL_BUS_TYPE_PCI;
> drivers/tty/synclinkmp.c:       unsigned int bus_type;
> /* expansion bus type (ISA,EISA,PCI) */
> drivers/tty/synclinkmp.c:               info->bus_type = MGSL_BUS_TYPE_PCI;

Despite the similar names these are actually two drivers entirely
separate form the main synclink one.