linux-kernel - Re: [PATCH] hwrng: imx-rngc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2473540.1Sv8tvBx5K@n95hx1g2>
Date:   Tue, 28 Jul 2020 10:47:29 +0200
From:   Christian Eggers <ceggers@...i.de>
To:     Marco Felsch <m.felsch@...gutronix.de>
CC:     Fabio Estevam <festevam@...il.com>,
        Martin Kaiser <martin@...ser.cx>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Arnd Bergmann <arnd@...db.de>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        <linux-kernel@...r.kernel.org>, NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        "Matt Mackall" <mpm@...enic.com>, Shawn Guo <shawnguo@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH] hwrng: imx-rngc - setup default RNG quality

Hi Marco,

On Tuesday, 28 July 2020, 09:48:17 CEST, Marco Felsch wrote:
> Hi Christian,
> 
> On 20-07-27 14:45, Christian Eggers wrote:
> > When hw_random device's quality is non-zero, it will automatically fill
> > the kernel's entropy pool at boot.  For this purpose, one conservative
> > quality value is being picked up as the default value.
> 
> IMHO your value is not conservative enough and the commit message should
> explain why we should use 900. Unfortunately I had not enough time to
> send my patch addressing this. However please check my commit message
> why 900 is not good:
ok, you caught me. I found the value of 900 in several other drivers and 
simply took it. Even parts of my commit message were simply copied...

As I have no real idea about determining the right quality, I will leave this 
task for you :-)

Thanks
Christian