linux-kernel - Re: [PATCH RFC v5 4/6] drm/sprd: add Unisoc's drm display controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFPSGXaERhtja=hZdKcuBJf-wtiT4RbM50UcT2wNBBAa2bq-Uw@mail.gmail.com>
Date:   Tue, 28 Jul 2020 18:18:01 +0800
From:   Kevin Tang <kevin3.tang@...il.com>
To:     Emil Velikov <emil.l.velikov@...il.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Sean Paul <sean@...rly.run>, Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Orson Zhai <orsonzhai@...il.com>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        Baolin Wang <baolin.wang@...aro.org>
Subject: Re: [PATCH RFC v5 4/6] drm/sprd: add Unisoc's drm display controller driver

Hi Emil,
Sorry, I left for a long time because of other things. Now i'm back~

V6 fix access registers via readl/writel, check unsupported KMS
properties (format, rotation, blend mode, etc) by plane_check callback
ops
and remove always true checks for dpu core ops

Add changelog within the corresponding patch from now on, thanks for
your advice.

BR,
Kevin


Emil Velikov <emil.l.velikov@...il.com> 于2020年3月20日周五 上午2:07写道：
>
> Hey Kevin,
>
> On Sun, 15 Mar 2020 at 23:19, Kevin Tang <kevin3.tang@...il.com> wrote:
> >
> > Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem.
> > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more.
> >
> > Cc: Orson Zhai <orsonzhai@...il.com>
> > Cc: Baolin Wang <baolin.wang@...aro.org>
> > Cc: Chunyan Zhang <zhang.lyra@...il.com>
> > Signed-off-by: Kevin Tang <kevin.tang@...soc.com>
> > ---
> >  drivers/gpu/drm/sprd/Makefile       |   5 +-
> >  drivers/gpu/drm/sprd/dpu/Makefile   |   7 +
> >  drivers/gpu/drm/sprd/dpu/dpu_r2p0.c | 750 ++++++++++++++++++++++++++++++++++++
> >  drivers/gpu/drm/sprd/sprd_dpu.c     | 501 ++++++++++++++++++++++++
> >  drivers/gpu/drm/sprd/sprd_dpu.h     | 170 ++++++++
> >  drivers/gpu/drm/sprd/sprd_drm.c     |   1 +
> >  drivers/gpu/drm/sprd/sprd_drm.h     |   2 +
>
> Seems like v5 (patch at least, I did not look at the rest) does not
> address a handful of the feedback.
>  - Access registers via readl/writel, instead of current approach
>  - With ^^ you can drop the compiler workaround
>  - Checking for unsupported KMS properties (format, rotation, etc)
> should happen in the XXX_check callbacks
>  - Remove always true checks, around the (rather moot) abstraction layer
>
> For the future, please keep the revision/changelog within the
> corresponding patch. This way reviewers can see, from the onset, what
> is addressed.
> Look at `git log -- drivers/gpu/drm` for examples.
>
>
> -Emil