linux-kernel - Re: [PATCH v4 1/3] arm64: dts: Add a device tree for the Librem 5 phone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3555a1ae-aeaf-196d-18b4-8615f90c854a@puri.sm>
Date:   Tue, 28 Jul 2020 12:43:38 +0200
From:   Martin Kepplinger <martin.kepplinger@...i.sm>
To:     Pavel Machek <pavel@....cz>
Cc:     robh@...nel.org, kernel@...i.sm, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, mchehab@...nel.org, Anson.Huang@....com,
        agx@...xcpu.org, angus@...ea.ca, broonie@...nel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Daniel Baluta <daniel.baluta@....com>
Subject: Re: [PATCH v4 1/3] arm64: dts: Add a device tree for the Librem 5
 phone

On 27.07.20 14:02, Pavel Machek wrote:
> Hi!
> 
>> +	pwmleds {
>> +		compatible = "pwm-leds";
>> +
>> +		blue {
>> +			label = "blue:status";
>> +			max-brightness = <248>;
>> +			pwms = <&pwm2 0 50000>;
>> +		};
>> +
>> +		green {
>> +			label = "green:status";
>> +			max-brightness = <248>;
>> +			pwms = <&pwm4 0 50000>;
>> +		};
>> +
>> +		red {
>> +			label = "red:status";
>> +			max-brightness = <248>;
>> +			pwms = <&pwm3 0 50000>;
>> +		};
>> +	};
> 
> Can we postpone this?

I guess we can. It's indeed easier to add that interface once we know we
can use a stable one.

> 
> 1) green:status is not really name used anywhere else
> 
> 2) this should really use multicolor framework, as it is single LED,
> not three of them.
> 
> Fixing that in future will be hard :-(.
> 								Pavel
> 								
> 

thanks,
                              martin