linux-kernel - [PATCH] gpiolib: of: reset name variable in of_gpiochip_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200728134226.27592-1-trix@redhat.com>
Date:   Tue, 28 Jul 2020 06:42:26 -0700
From:   trix@...hat.com
To:     linus.walleij@...aro.org, bgolaszewski@...libre.com,
        frank.rowand@...y.com, geert+renesas@...der.be
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tom Rix <trix@...hat.com>
Subject: [PATCH] gpiolib: of: reset name variable in of_gpiochip_add_hog

From: Tom Rix <trix@...hat.com>

Clang static analysis reports this error

gpiolib-of.c:664:9: warning: 2nd function call argument
  is an uninitialized value [core.CallAndMessage]
        ret = gpiod_hog(desc, name, lflags, dflags);

name is sometimes set by of_parse_own_gpio
name is always used by gpiod_hog

So it is necessary to reset name so an old value is
not mistakenly used by gpiod_hog.

Fixes: bc21077e084b ("gpio: of: Extract of_gpiochip_add_hog()")

Signed-off-by: Tom Rix <trix@...hat.com>
---
 drivers/gpio/gpiolib-of.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index bd31dd3b6a75..277ada41d04a 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -657,6 +657,7 @@ static int of_gpiochip_add_hog(struct gpio_chip *chip, struct device_node *hog)
 	int ret;
 
 	for (i = 0;; i++) {
+		name = NULL;
 		desc = of_parse_own_gpio(hog, chip, i, &name, &lflags, &dflags);
 		if (IS_ERR(desc))
 			break;
-- 
2.18.1