linux-kernel - Re: [External] Re: [PATCH 4.19 00/86] 4.19.135-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+G9fYs__nNa-090Cm8j_EPYGRfh+y+VTX3ZqR_W1Jcu2suNEQ@mail.gmail.com>
Date:   Tue, 28 Jul 2020 20:05:16 +0530
From:   Naresh Kamboju <naresh.kamboju@...aro.org>
To:     Muchun Song <songmuchun@...edance.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        open list <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Shuah Khan <shuah@...nel.org>, patches@...nelci.org,
        Ben Hutchings <ben.hutchings@...ethink.co.uk>,
        linux- stable <stable@...r.kernel.org>,
        Hugh Dickins <hughd@...gle.com>,
        Christoph Lameter <cl@...ux.com>, Roman Gushchin <guro@...com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        linux-mm <linux-mm@...ck.org>, mm-commits@...r.kernel.org,
        Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Shakeel Butt <shakeelb@...gle.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Arnd Bergmann <arnd@...db.de>, lkft-triage@...ts.linaro.org,
        clang-built-linux@...glegroups.com
Subject: Re: [External] Re: [PATCH 4.19 00/86] 4.19.135-rc1 review

On Tue, 28 Jul 2020 at 18:33, Muchun Song <songmuchun@...edance.com> wrote:
>
> Thanks for your test. I have reviewed the patch:
>
> [PATCH 4.19 76/86] mm: memcg/slab: fix memory leak at non-root
> kmem_cache destroy
>
> There is a backport problem and I have pointed out the problem in that email.

Thanks for your suggestions on the other email thread.
I have made changes as you said and boot test pass on x86 now.

diff --git a/mm/slab_common.c b/mm/slab_common.c
index 9c5eb4b08fc3..65bc49f19504 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -842,9 +842,7 @@ static int shutdown_memcg_caches(struct kmem_cache *s)

 static void memcg_set_kmem_cache_dying(struct kmem_cache *s)
 {
-       mutex_lock(&slab_mutex);
        s->memcg_params.dying = true;
-       mutex_unlock(&slab_mutex);
 }

 static void flush_memcg_workqueue(struct kmem_cache *s)

- Naresh