linux-kernel - Re: [PATCH] m68k/amiga: Add missing platform_device_unregister() call in amiga_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e12105b-aa72-11a2-74f6-c789f8ceaaa3@web.de>
Date:   Tue, 28 Jul 2020 16:50:06 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Qinglang Miao <miaoqinglang@...wei.com>,
        linux-m68k@...ts.linux-m68k.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] m68k/amiga: Add missing platform_device_unregister() call
 in amiga_init_devices()

> Add the missing platform_device_unregister() before return
> from amiga_init_devices() in the error handling case.

Will the tag “Fixes” become helpful for the commit message?


…
> +++ b/arch/m68k/amiga/platform.c
> @@ -188,8 +188,10 @@  static int __init amiga_init_devices(void)
>  			return PTR_ERR(pdev);
>  		error = platform_device_add_data(pdev, &a1200_ide_pdata,
>  						 sizeof(a1200_ide_pdata));
> -		if (error)
> +		if (error) {
> +			platform_device_unregister(pdev);
>  			return error;
> +		}
>  	}
…

I suggest to add a jump target for the desired exception handling.

 		if (error)
+			goto unregister_device;


Regards,
Markus