linux-kernel - Re: [RFC][PATCH] locking/refcount: Provide _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Jul 2020 12:30:22 -0700
From:   Kees Cook <keescook@...omium.org>
To:     peterz@...radead.org
Cc:     David Howells <dhowells@...hat.com>, Will Deacon <will@...nel.org>,
        Xiaoming Ni <nixiaoming@...wei.com>,
        David Windsor <dwindsor@...il.com>,
        Hans Liljestrand <ishkamiel@...il.com>,
        Elena Reshetova <elena.reshetova@...el.com>,
        Paul Moore <paul@...l-moore.com>, edumazet@...gle.com,
        paulmck@...nel.org, shakeelb@...gle.com,
        James Morris <jamorris@...ux.microsoft.com>,
        alex.huangjianhui@...wei.com, dylix.dailei@...wei.com,
        chenzefeng2@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH] locking/refcount: Provide __refcount API to obtain
 the old value

On Wed, Jul 29, 2020 at 01:11:20PM +0200, peterz@...radead.org wrote:
> Subject: locking/refcount: Provide __refcount API to obtain the old value
> From: Peter Zijlstra <peterz@...radead.org>
> Date: Wed Jul 29 13:00:57 CEST 2020
> 
> David requested means to obtain the old/previous value from the
> refcount API for tracing purposes.
> 
> Duplicate (most of) the API as __refcount*() with an additional
> 'int *' argument into which, if !NULL, the old value will be stored.
> 
> Requested-by: David Howells <dhowells@...hat.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>

This looks good to me. Thanks for poking at it!

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook