linux-kernel - Re: [PATCH 2/2] soc: qcom: smd-rpm: Fix kerneldoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200729204628.GL229995@builder.lan>
Date:   Wed, 29 Jul 2020 13:46:28 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        Andy Gross <agross@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/2] soc: qcom: smd-rpm: Fix kerneldoc

On Wed 29 Jul 00:44 PDT 2020, Krzysztof Kozlowski wrote:

> Fix W=1 compile warnings (invalid kerneldoc):
> 
>     drivers/soc/qcom/smd-rpm.c:35: warning: Function parameter or member 'dev' not described in 'qcom_smd_rpm'
>     drivers/soc/qcom/smd-rpm.c:99: warning: Function parameter or member 'state' not described in 'qcom_rpm_smd_write'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Thanks for spotting these, applied.

PS. This doesn't have any relationship with the Mediatek patch, the two
goes through different maintainer trees and my manual mailbox filter
almost discarded the series. So please send patches like this
individually in the future.

Thanks,
Bjorn

> ---
>  drivers/soc/qcom/smd-rpm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c
> index 877b13850730..1d4eb46b417a 100644
> --- a/drivers/soc/qcom/smd-rpm.c
> +++ b/drivers/soc/qcom/smd-rpm.c
> @@ -20,6 +20,7 @@
>   * struct qcom_smd_rpm - state of the rpm device driver
>   * @rpm_channel:	reference to the smd channel
>   * @icc:		interconnect proxy device
> + * @dev:		rpm device
>   * @ack:		completion for acks
>   * @lock:		mutual exclusion around the send/complete pair
>   * @ack_status:		result of the rpm request
> @@ -86,6 +87,7 @@ struct qcom_rpm_message {
>  /**
>   * qcom_rpm_smd_write - write @buf to @type:@id
>   * @rpm:	rpm handle
> + * @state:	active/sleep state flags
>   * @type:	resource type
>   * @id:		resource identifier
>   * @buf:	the data to be written
> -- 
> 2.17.1
>