linux-kernel - Re: [PATCH] PCI: Move pci_info() after pci_fixup_device() in pci_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200729225341.GA1973599@bjorn-Precision-5520>
Date:   Wed, 29 Jul 2020 17:53:41 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: Move pci_info() after pci_fixup_device() in
 pci_setup_device()

On Mon, Jul 27, 2020 at 03:06:55PM +0800, Tiezhu Yang wrote:
> In the current code, we can not see the PCI info after fixup which is
> correct to reflect the reality, it is better to move pci_info() after
> pci_fixup_device() in pci_setup_device().
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>

Applied to pci/enumeration for v5.9, thanks!

> ---
>  drivers/pci/probe.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 2f66988..7c046aed 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -1802,9 +1802,6 @@ int pci_setup_device(struct pci_dev *dev)
>  	dev->revision = class & 0xff;
>  	dev->class = class >> 8;		    /* upper 3 bytes */
>  
> -	pci_info(dev, "[%04x:%04x] type %02x class %#08x\n",
> -		   dev->vendor, dev->device, dev->hdr_type, dev->class);
> -
>  	if (pci_early_dump)
>  		early_dump_pci_device(dev);
>  
> @@ -1822,6 +1819,9 @@ int pci_setup_device(struct pci_dev *dev)
>  	/* Early fixups, before probing the BARs */
>  	pci_fixup_device(pci_fixup_early, dev);
>  
> +	pci_info(dev, "[%04x:%04x] type %02x class %#08x\n",
> +		 dev->vendor, dev->device, dev->hdr_type, dev->class);
> +
>  	/* Device class may be changed after fixup */
>  	class = dev->class >> 8;
>  
> -- 
> 2.1.0
>